Merge pull request #430 from Shopify/add_redis_client_options

Allow redis options in session storage
Shopify · Jul 25, 2022 · 16c8e33 · 16c8e33
2 parents 20c8b8d + 7ea3f39
commit 16c8e33
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,8 @@ and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 ## Unreleased
 
+- Allow passing in options for the Redis client used by the session storage strategy [#430](https://github.com/Shopify/shopify-api-node/pull/430)
+
 ## [4.2.0] - 2022-07-20
 
 - Return a 401 instead of 403 when webhooks fail validation [#425](https://github.com/Shopify/shopify-api-node/pull/425)

diff --git a/src/auth/session/storage/redis.ts b/src/auth/session/storage/redis.ts
@@ -1,10 +1,10 @@
-import {createClient, RedisClientType} from 'redis';
+import {createClient, RedisClientType, RedisClientOptions} from 'redis';
 
 import {SessionInterface} from '../types';
 import {SessionStorage} from '../session_storage';
 import {sessionFromEntries, sessionEntries} from '../session-utils';
 
-export interface RedisSessionStorageOptions {
+export interface RedisSessionStorageOptions extends RedisClientOptions {
   sessionKeyPrefix: string;
 }
 const defaultRedisSessionStorageOptions: RedisSessionStorageOptions = {
@@ -103,6 +103,7 @@ export class RedisSessionStorage implements SessionStorage {
 
   private async init() {
     this.client = createClient({
+      ...this.options,
       url: this.dbUrl.toString(),
     });
     await this.client.connect();