Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Put emphasis on having .env in gitignore + add resource to rotate credentials #107

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

NicholasEllul
Copy link
Contributor

WHY are these changes introduced?

We've noticed in the past that app developers will mistakenly commit credentials to GitHub. This revises the doc to put more emphasis on the importance of not missing this step to prevent that, as well as add a link to how they can rotate their credentials.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@NicholasEllul NicholasEllul requested a review from a team as a code owner February 10, 2021 21:46
@NicholasEllul NicholasEllul force-pushed the ellul/gitignore-very-important branch from 249668c to deae0c1 Compare February 10, 2021 21:47
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@thecodepixi thecodepixi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! 👍

@NicholasEllul NicholasEllul merged commit 7b63efe into main Feb 10, 2021
@NicholasEllul NicholasEllul deleted the ellul/gitignore-very-important branch February 10, 2021 22:18
@paulomarg paulomarg temporarily deployed to production February 18, 2021 16:24 Inactive
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants