This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 387
Add support for PubSub webhook registration #181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎩
|
james-langille
approved these changes
May 17, 2021
mikedasilva
reviewed
May 17, 2021
mikedasilva
reviewed
May 17, 2021
mikedasilva
reviewed
May 17, 2021
mikedasilva
reviewed
May 17, 2021
mikedasilva
reviewed
May 17, 2021
mikedasilva
reviewed
May 17, 2021
mikedasilva
approved these changes
May 17, 2021
thecodepixi
approved these changes
May 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! Just left a few nit-ish comments and one question for you.
6 tasks
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We will soon have support for webhook delivery via Google Cloud PubSub.
We need to update the webhook registration function in this library to support this new delivery method.
WHAT is this pull request doing?
The
register
function already takes in aDeliveryMethod
. This PR adds a newDeliveryMethod.PubSub
,and implements the appropriate behaviour for it. In particular,
register
hits the newpubSubWebhookSubscriptionCreate
and
pubSubWebhookSubscriptionUpdate
endpoints in the GraphQL API.This PR also adds some documentation about registering non-HTTP-delivery webhooks (the docs for
EventBridge webhooks were missing as well).
Type of change
Checklist