Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Add 2022-07, remove 2021-07 REST Resources #415

Merged
merged 4 commits into from
Jul 4, 2022
Merged

Add 2022-07, remove 2021-07 REST Resources #415

merged 4 commits into from
Jul 4, 2022

Conversation

mkevinosullivan
Copy link
Contributor

WHY are these changes introduced?

To support the quarterly addition/deprecation of API versions.

Does the Node part of https://github.com/Shopify/first-party-library-planning/issues/372

WHAT is this pull request doing?

  • Adds REST resources for 2022-07
  • Removes REST resources for 2021-07
  • Adds new LATEST_API_VERSION constant and points it to 2022-07

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@mkevinosullivan mkevinosullivan requested a review from a team as a code owner June 29, 2022 20:02
@mkevinosullivan mkevinosullivan force-pushed the add_2022-07_remove_2021-07 branch from 3a026c8 to 7315fc9 Compare June 29, 2022 20:04
GalDayan
GalDayan approved these changes Jul 4, 2022
View reviewed changes
Copy link

@GalDayan GalDayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When are you going to release it?

@meifif
Copy link

meifif commented Jul 4, 2022 •
edited
Loading

Great job, any timeline on release?

@mkevinosullivan mkevinosullivan force-pushed the add_2022-07_remove_2021-07 branch from 7315fc9 to 2cb710a Compare July 4, 2022 13:46
paulomarg
paulomarg approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, but LGTM otherwise!

src/index.ts Outdated Show resolved Hide resolved
@mkevinosullivan mkevinosullivan force-pushed the add_2022-07_remove_2021-07 branch from 098e30c to afeb0d4 Compare July 4, 2022 15:15
@mkevinosullivan mkevinosullivan merged commit 7112182 into main Jul 4, 2022
@mkevinosullivan mkevinosullivan deleted the add_2022-07_remove_2021-07 branch July 4, 2022 15:23
@shopify-shipit shopify-shipit bot temporarily deployed to production July 4, 2022 16:01 Inactive
@maorRoz
Copy link

maorRoz commented Jul 5, 2022

@mkevinosullivan @paulomarg
Now that this code is merged, is it possible to publish a new version of this lib?

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@ork-acro ork-acro ork-acro approved these changes

@paulomarg paulomarg paulomarg approved these changes

@maorRoz maorRoz maorRoz approved these changes

@meifif meifif meifif approved these changes

@GalDayan GalDayan GalDayan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mkevinosullivan @meifif @maorRoz @GalDayan @paulomarg @ork-acro