This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Return 401 on webhook validation errors #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
return_401_on_webhook_failure
branch
from
ee53114 to
25aa560
Compare
paulomarg
force-pushed
the
return_401_on_webhook_failure
branch
from
25aa560 to
852c9d5
Compare
mkevinosullivan
approved these changes
Jul 20, 2022
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Closes #396
Shopify rejects apps that don't return a
401 Unauthorizedresponse when they receive an invalid HMAC in a webhook request, and the library currently returns 403.WHAT is this pull request doing?
Changing the response code in that scenario to 401. Also changing the "handler not found" scenario to return a 404 instead.
Type of change
Checklist