Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Add processing of X-Shopify-API-Version to webhook processing #630

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Add processing of X-Shopify-API-Version to webhook processing #630

merged 2 commits into from
Dec 8, 2022

Conversation

mkevinosullivan
Copy link
Contributor

@mkevinosullivan mkevinosullivan commented Dec 8, 2022 •
edited
Loading

WHY are these changes introduced?

API library component for Shopify/shopify-app-js#29

WHAT is this pull request doing?

Add processing of X-Shopify-API-Version header to webhook processing, and pass it as an optional parameter to the webhook handler.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@mkevinosullivan mkevinosullivan requested a review from a team as a code owner December 8, 2022 16:49
@mkevinosullivan mkevinosullivan force-pushed the kos/add_api_version_header_to_webhook_handers branch from 2f4d659 to 527c1c6 Compare December 8, 2022 16:57
paulomarg
paulomarg approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, but LGTM otherwise.

lib/webhooks/types.ts Outdated Show resolved Hide resolved
@mkevinosullivan mkevinosullivan force-pushed the kos/add_api_version_header_to_webhook_handers branch from 8e66d03 to c6ca84f Compare December 8, 2022 19:03
@mkevinosullivan mkevinosullivan merged commit 2e40680 into main Dec 8, 2022
@mkevinosullivan mkevinosullivan deleted the kos/add_api_version_header_to_webhook_handers branch December 8, 2022 19:11
@shopify-shipit shopify-shipit bot temporarily deployed to production December 8, 2022 20:09 Inactive
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@paulomarg paulomarg paulomarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkevinosullivan @paulomarg