-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: statefulsets, daemonsets, jobs and volumes implementation in k8s infra monitoring #6629
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
b5d57e1
to
ba944d0
Compare
186f768
to
6d441f3
Compare
c89ffab
to
79cae2d
Compare
a294614
to
6855009
Compare
2edb730
to
579c7cb
Compare
579c7cb
to
22a33e3
Compare
a9011ac
to
152b1b9
Compare
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 152b1b9 in 2 minutes and 7 seconds
More details
- Looked at
4611
lines of code in33
files - Skipped
0
files when reviewing. - Skipped posting
9
drafted comments based on config settings.
1. frontend/src/api/infraMonitoring/getK8sJobsList.ts:70
- Draft comment:
Consider adding more robust error handling for network errors or unexpected responses to improve reliability. - Reason this comment was not posted:
Confidence changes required:50%
The functiongetK8sJobsList
is used to fetch data, but the error handling is not robust. It should handle network errors or unexpected responses more gracefully.
2. frontend/src/container/InfraMonitoringK8s/Jobs/K8sJobsList.tsx:301
- Draft comment:
Consider definingexpandedRowRender
outside the component or usinguseCallback
to prevent unnecessary re-renders. - Reason this comment was not posted:
Confidence changes required:40%
TheexpandedRowRender
function is defined within theK8sJobsList
component, which could lead to unnecessary re-renders. It would be better to define it outside the component or useuseCallback
to memoize it.
3. frontend/src/container/InfraMonitoringK8s/Jobs/K8sJobsList.tsx:222
- Draft comment:
EnsuresetCurrentPage
andsetOrderBy
are included in the dependency array ofuseCallback
forhandleTableChange
. - Reason this comment was not posted:
Confidence changes required:30%
ThehandleTableChange
function is defined usinguseCallback
, which is good for performance. However, it should includesetCurrentPage
andsetOrderBy
in its dependency array to ensure it always has the latest references.
4. frontend/src/container/InfraMonitoringK8s/Jobs/K8sJobsList.tsx:397
- Draft comment:
IncludesetGroupBy
andsetExpandedRowKeys
in the dependency array ofuseCallback
forhandleGroupByChange
. - Reason this comment was not posted:
Confidence changes required:30%
ThehandleGroupByChange
function usesuseCallback
but does not includesetGroupBy
andsetExpandedRowKeys
in its dependency array. This could lead to stale closures.
5. frontend/src/container/InfraMonitoringK8s/Jobs/JobDetails/Logs/JobLogsDetailedView.tsx:66
- Draft comment:
Avoid using inline styles. Use external stylesheets or styled components instead. This applies to other instances in this file as well. - Reason this comment was not posted:
Comment looked like it was already resolved.
6. frontend/src/container/InfraMonitoringK8s/Jobs/JobDetails/Metrics/JobMetrics.tsx:100
- Draft comment:
Avoid using inline styles. Use external stylesheets or styled components instead. This applies to other instances in this file as well. - Reason this comment was not posted:
Marked as duplicate.
7. frontend/src/container/InfraMonitoringK8s/Jobs/JobDetails/Traces/JobTraces.tsx:165
- Draft comment:
Avoid using inline styles. Use external stylesheets or styled components instead. This applies to other instances in this file as well. - Reason this comment was not posted:
Marked as duplicate.
8. frontend/src/container/InfraMonitoringK8s/Jobs/K8sJobsList.tsx:304
- Draft comment:
Avoid using inline styles. Use external stylesheets or styled components instead. This applies to other instances in this file as well. - Reason this comment was not posted:
Marked as duplicate.
9. frontend/src/container/InfraMonitoringK8s/Jobs/utils.tsx:274
- Draft comment:
Avoid using inline styles. Use external stylesheets or styled components instead. This applies to other instances in this file as well. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_FuMuXRAIAnmIM4cN
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
8db8062
to
5ca6a1f
Compare
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 41281c9 in 52 seconds
More details
- Looked at
1667
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
5
drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/Nodes/NodeDetails/constants.ts:657
- Draft comment:
The 'disabled' property is set to 'true' for this query data. Ensure this is intentional. This is also applicable at lines 700, 743, 832, 875, 918, 1525, and 1568. - Reason this comment was not posted:
Confidence changes required:50%
The code contains multiple instances where the 'disabled' property is set to 'true' for query data. This might be intentional, but it's worth pointing out in case it's an oversight.
2. frontend/src/container/InfraMonitoringK8s/Nodes/NodeDetails/constants.ts:102
- Draft comment:
The 'reduceTo' property is set to 'avg'. Ensure this is intentional. This is also applicable at lines 145, 188, 231, 273, 349, 393, 436, 479, 521, 564, 607, 859, 902, 945, 1028, 1127, 1220, 1313, 1389, 1432, 1475, 1551, and 1594. - Reason this comment was not posted:
Confidence changes required:50%
The code has multiple instances where the 'reduceTo' property is set to 'avg'. This might be intentional, but it's worth pointing out in case it's an oversight.
3. frontend/src/container/InfraMonitoringK8s/Nodes/NodeDetails/constants.ts:103
- Draft comment:
The 'spaceAggregation' property is set to 'sum'. Ensure this is intentional. This is also applicable at lines 146, 189, 232, 274, 350, 394, 437, 480, 522, 565, 608, 860, 903, 946, 1029, 1128, 1221, 1314, 1390, 1433, 1476, 1552, and 1595. - Reason this comment was not posted:
Confidence changes required:50%
The code has multiple instances where the 'spaceAggregation' property is set to 'sum'. This might be intentional, but it's worth pointing out in case it's an oversight.
4. frontend/src/container/InfraMonitoringK8s/InfraMonitoringK8s.tsx:107
- Draft comment:
Avoid using thecomponent/index.tsx
file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable to other imports in this file as well. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
5. frontend/src/container/InfraMonitoringK8s/InfraMonitoringK8s.tsx:359
- Draft comment:
Avoid using thecomponent/index.tsx
file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable to other imports in this file as well. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_ODM3Sqwi6pM1HKpa
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
6a8cf85
to
e5099a4
Compare
Summary
implements statefulsets, daemonsets, jobs and volumes entities in infra monitoring
Related Issues / PR's
N/A
Screenshots
Affected Areas and Manually Tested Areas
Infra Monitoring section
Important
Adds monitoring support for Kubernetes StatefulSets, DaemonSets, Jobs, and Volumes in the infrastructure monitoring section with new API endpoints, UI components, and data models.
StatefulSets
,DaemonSets
,Jobs
, andVolumes
in Kubernetes infrastructure.StatefulSets
,DaemonSets
,Jobs
, andVolumes
.pkg/query-service/app/inframetrics
.StatefulSets
,DaemonSets
,Jobs
, andVolumes
inInfraMonitoringK8s
.StatefulSetListRecord
,DaemonSetListRecord
,JobListRecord
, andVolumeListRecord
inmodel/infra.go
.reactQueryKeys.ts
with new query keys for the added entities.model/infra.go
for new entity attributes.This description was created by for 6a8cf85. It will automatically update as commits are pushed.