feat: aws integration UI facing api: services #6803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raj-k-singh
force-pushed
the
feat/aws-integration-ui-facing-api-1
branch
from
6cf92b5 to
dc5f991
Compare
raj-k-singh
commented
Jan 14, 2025
pkg/query-service/app/cloudintegrations/serviceDefinitions/aws/rdsPostgres/integration.json
Show resolved
Hide resolved
raj-k-singh
commented
Jan 14, 2025
pkg/query-service/app/cloudintegrations/serviceDefinitions/aws/ec2/integration.json
Show resolved
Hide resolved
…lable svcs and some cleanup
…provider services
…en queried for cloud account id
…oud account can be configured
raj-k-singh
force-pushed
the
feat/aws-integration-ui-facing-api-1
branch
from
dc5f991 to
917cdd6
Compare
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 917cdd6 in 1 minute and 41 seconds
More details
- Looked at
1430lines of code in14files - Skipped
2files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. pkg/query-service/tests/integration/signoz_cloud_integrations_test.go:130
- Draft comment:
Consider adding tests for error scenarios, such as configuring a service for a non-connected account or an unsupported service, to improve coverage. - Reason this comment was not posted:
Confidence changes required:50%
The test functionTestAWSIntegrationServicesis missing tests for error scenarios, such as trying to configure a service for a non-connected account or an unsupported service. Adding these tests would improve coverage and robustness.
2. pkg/query-service/app/cloudintegrations/serviceConfigRepo.go:1
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable in other files as well. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_k9zPriTPQVEAK70X
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
raj-k-singh
commented
Jan 14, 2025
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on d6da8a6 in 27 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pkg/query-service/app/cloudintegrations/controller_test.go:183
- Draft comment:
Good practice to check forCloudAccountIdnot being nil before dereferencing. - Reason this comment was not posted:
Confidence changes required:0%
The change in the testTestConfigureServiceadds a check forCloudAccountIdbeing not nil before comparing it withtestCloudAccountId. This is a good practice to avoid potential nil pointer dereference errors.
Workflow ID: wflow_xBtlFjCbqZlFsVPp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
srikanthccv
approved these changes
Jan 16, 2025
amlannandy
pushed a commit
that referenced
this pull request
Jan 21, 2025
* feat: cloud service integrations: get model and repo interface started * feat: cloud service integrations: flesh out more of cloud services model * feat: cloud integrations: reorganize things a little * feat: cloud integrations: get svc controller started * feat: cloud integrations: add stubs for EC2 and RDS postgres services * feat: cloud integrations: add validation for listing and getting available svcs and some cleanup * feat: cloud integrations: refactor helpers in existing integrations code for reuse * feat: cloud integrations: parsing of cloud service definitions * feat: cloud integrations: impl for getCloudProviderService * feat: cloud integrations: some reorganization * feat: cloud integrations: some more cleanup * feat: cloud integrations: add validation for listing available cloud provider services * feat: cloud integrations: API endpoint for listing available cloud provider services * feat: cloud integrations: add validation for getting details of a particular service * feat: cloud integrations: API endpoint for getting details of a service * feat: cloud integrations: add controller validation for configuring cloud services * feat: cloud integrations: get serviceConfigRepo started * feat: cloud integrations: service config in service list summaries when queried for cloud account id * feat: cloud integrations: only a supported service for a connected cloud account can be configured * feat: cloud integrations: add validation for configuring services via the API * feat: cloud integrations: API for configuring services * feat: cloud integrations: some cleanup * feat: cloud integrations: fix broken test --------- Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds APIs for listing and configuring cloud services for AWS integration
Related Issues / PR's
Contributes to #6544
Important
Add APIs and models for AWS cloud service integration, including service listing, detail retrieval, and configuration updates, with corresponding tests.
ListServices,GetServiceDetails, andUpdateServiceConfigfunctions incontroller.gofor AWS cloud services.http_handler.gofor listing, retrieving details, and updating service configurations.CloudServiceSummary,CloudServiceDetails, andCloudServiceConfiginmodel.go.serviceConfigRepositoryinterface and implementation inserviceConfigRepo.go.EC2andRDS PostgresinserviceDefinitions/aws/.signoz_cloud_integrations_test.gofor service listing, detail retrieval, and configuration updates.repo.gotoaccountsRepo.goandInitSqliteDBIfNeededtoinitAccountsSqliteDBIfNeeded.This description was created by
for d6da8a6. It will automatically update as commits are pushed.