chore(install-script): install.sh script improvements #6857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to d73a0b6 in 1 minute and 24 seconds
More details
- Looked at
172lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. deploy/install.sh:36
- Draft comment:
Consider usingis_command_presentfor checking docker compose plugin for consistency.
has_docker_compose_plugin() {
is_command_present "docker compose"
}
- Reason this comment was not posted:
Confidence changes required:50%
The functionhas_docker_compose_pluginchecks for the docker compose plugin, but the functionis_command_presentis used elsewhere to check for command presence. It would be more consistent to useis_command_presentfor checking docker compose plugin as well.
2. deploy/install.sh:479
- Draft comment:
Consider defining port numbers as constants at the top of the script for better maintainability. - Reason this comment was not posted:
Confidence changes required:50%
Thecheck_ports_occupiedfunction uses hardcoded port numbers 3301 and 4317. It would be better to define these as constants at the top of the script for easier maintenance and readability.
3. deploy/install.sh:428
- Draft comment:
Duplicate assignment foreventvariable insend_eventfunction. Remove the redundant line. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_ED6OCRIxi04tLboe
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Signed-off-by: Prashant Shahi <prashant@signoz.io>
grandwizard28
approved these changes
Jan 20, 2025
Related Issue |
grandwizard28
added a commit
that referenced
this pull request
Jan 20, 2025
feat: add search span scope in the list view tab to add the scope at per Query level (#6810) * feat: add search span scope in the list view tab to add the scope at per query level * feat: add search span scope in the list view tab to add the scope at per query level * feat: add search span scope in the list view tab to add the scope at per query level * feat: add search span scope in the list view tab to add the scope at per query level * feat: add search span scope in the list view tab to add the scope at per query level * feat: add search span scope in the list view tab to add the scope at per query level * feat: add search span scope in the list view tab to add the scope at per query level * feat: add search span scope in the list view tab to add the scope at per query level * feat: add search span scope in the list view tab to add the scope at per query level * feat: add search span scope in the list view tab to add the scope at per query level * feat: add search span scope in the list view tab to add the scope at per query level chore(install-script): install.sh script improvements (#6857) - support for docker compose plugin - check for occupied port when installing SigNoz for the first time - remove unused code Signed-off-by: Prashant Shahi <prashant@signoz.io> chore: correct order within page result (#6847)
|
This is not working |
|
@RecoX can you please share the commands that you followed and also the OS and arch type? |
amlannandy
pushed a commit
that referenced
this pull request
Jan 21, 2025
### Summary - support for docker compose plugin - check for occupied port when installing SigNoz for the first time - remove unused code Signed-off-by: Prashant Shahi <prashant@signoz.io>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Important
Improved
install.shby adding Docker Compose plugin support, checking for occupied ports, and removing unused code.has_docker_compose_plugin()to check for Docker Compose plugin.docker_compose_cmdto use eitherdocker composeordocker-composebased on availability.docker-composecommands to use$docker_compose_cmd.install.sh.This description was created by
for d73a0b6. It will automatically update as commits are pushed.