feat(sqlmigration): consolidate all sqlmigrations into one package

[grandwizard28]

Summary

• consolidate all sqlmigrations into one package
• remove unused imports and redundant code related to old migration methods
• fix telemetrystoretest
• Validate configuration to ensure all fields implement factory.Config interface

Related Issues / PR's

---

Important

Consolidate SQL migrations into a single package, update configuration validation, and streamline test setup for SQLite databases.

• SQL Migrations:
  • Consolidate all SQL migrations into a single package.
  • Remove redundant code and unused imports related to old migration methods in server.go, modelDao.go, and db.go.
• Configuration:
  • Validate configuration to ensure all fields implement factory.Config interface in config.go.
• Testing:
  • Update test setup for SQLite databases in testutils.go to use new migration setup.
• Telemetry Store:
  • Update telemetry store configuration in config.go to support only clickhouse provider.
• Miscellaneous:
  • Remove deprecated environment variables and flags in config.go.
  • Update provider.go to include new SQL migration factories.

^{This description was created by for 42fe92c. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Incremental review on d44e1e8 in 1 minute and 9 seconds

More details

• Looked at 253 lines of code in 7 files
• Skipped 0 files when reviewing.
• Skipped posting 11 drafted comments based on config settings.

1. pkg/signoz/config.go:104

• Draft comment:
  Consider using a structured logger (e.g., zap.L()) instead of fmt.Println for deprecation warnings for consistency and better production logging.
• Reason this comment was not posted:
  Comment was on unchanged code.

2. pkg/telemetrystore/config.go:60

• Draft comment:
  Ensure that the hardcoded provider value ('clickhouse') in Validate() is intentional; otherwise, consider supporting additional providers or clarifying the limitation in documentation.
• Reason this comment was not posted:
  Confidence changes required: 33%
  None

3. pkg/telemetrystore/telemetrystore.go:10

• Draft comment:
  The TelemetryStore interface focuses solely on ClickHouse; ensure that this minimal interface aligns with project design and that no non–ClickHouse functions are inadvertently added.
• Reason this comment was not posted:
  Confidence changes required: 33%
  None

4. pkg/telemetrystore/telemetrystoretest/provider.go:29

• Draft comment:
  The mock provider implementation looks correct; just ensure type assertions on 'p.mock' are safe under all testing scenarios.
• Reason this comment was not posted:
  Confidence changes required: 0%
  None

5. pkg/telemetrystore/telemetrystoretest/provider_test.go:29

• Draft comment:
  Tests for provider instantiation and methods are adequate; ensure edge cases are covered in future tests if mocking becomes more complex.
• Reason this comment was not posted:
  Confidence changes required: 0%
  None

6. ee/query-service/app/server.go:150

• Draft comment:
  Removal of the STORAGE env variable check simplifies initialization and enforces use of ClickHouse. Ensure that all related deployment documentation and deprecation notices are updated accordingly.
• Reason this comment was not posted:
  Comment did not seem useful.

7. pkg/query-service/app/server.go:125

• Draft comment:
  The conditional check based on the STORAGE env variable was removed and the clickhouseReader is now used unconditionally. Verify that this change is reflected in your documentation and that users are aware that only ClickHouse is supported.
• Reason this comment was not posted:
  Marked as duplicate.

8. pkg/query-service/app/server.go:588

• Draft comment:
  Replace the use of fmt.Println with structured logging (e.g., using zap.L().Info) for consistent log output.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

9. pkg/signoz/config.go:103

• Draft comment:
  Consider replacing fmt.Println calls in mergeAndEnsureBackwardCompatibility with structured logger calls (e.g., zap.L().Warn) to maintain consistency with the rest of the codebase.
• Reason this comment was not posted:
  Marked as duplicate.

10. pkg/telemetrystore/config.go:46

• Draft comment:
  The Validate() method restricts Provider to 'clickhouse'. Consider using a constant for 'clickhouse' rather than a magic string to ease future changes and improve maintainability.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

11. pkg/telemetrystore/telemetrystoretest/provider.go:30

• Draft comment:
  The type assertion in ClickHouseDB() directly casts p.mock to clickhouse.Conn. Consider performing a safe type assertion to guard against potential panics if the underlying type changes.
• Reason this comment was not posted:
  Comment was on unchanged code.

Workflow ID: wflow_PsR1S8kuGsXWNF0V

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 42fe92c in 23 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. pkg/telemetrystore/config.go:54

• Draft comment:
  Ensure that switching the DSN scheme to 'tcp://' aligns with ClickHouse requirements. Confirm that no downstream dependencies expect the 'http://' format.
• Reason this comment was not posted:
  Comment did not seem useful.

2. pkg/telemetrystore/config.go:54

• Draft comment:
  Changed DSN from 'http' to 'tcp' for accurate ClickHouse connection. Consider adding a comment on this choice.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_azqFivtbcH24mm8i

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[nityanandagohain]

Looks good to me. Few minor comments.

I would suggest deploying this to a fresh instance and testing before merging. Just to avoid any misses.