Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(licenses): update the license events and the state names #7021

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

vikrantgupta25
Copy link
Member

@vikrantgupta25 vikrantgupta25 commented Feb 4, 2025

Summary

  • changes for query service and frontend to adapt based on new license states

@github-actions github-actions bot added the chore label Feb 4, 2025
@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review February 4, 2025 08:19
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c64af11 in 54 seconds

More details
  • Looked at 86 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 12 drafted comments based on config settings.
1. ee/query-service/model/license.go:142
  • Draft comment:
    Update comment to reflect the new license status constant name (INVALID) instead of inactive.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. ee/query-service/model/plans.go:24
  • Draft comment:
    Renamed constant to LicenseStatusInvalid. Ensure any related comments/documentation are updated accordingly.
  • Reason this comment was not posted:
    Marked as duplicate.
3. frontend/src/AppRoutes/Private.tsx:159
  • Draft comment:
    Updated state check from PAYMENT_FAILED to DEFAULTED; verify that this change aligns with backend logic.
  • Reason this comment was not posted:
    Comment did not seem useful.
4. frontend/src/container/AppLayout/index.tsx:253
  • Draft comment:
    Changed event check from FAILED_PAYMENT to DEFAULT; ensure that the new LicenseEvent.DEFAULT is intended for payment failure scenarios.
  • Reason this comment was not posted:
    Comment did not seem useful.
5. frontend/src/pages/WorkspaceSuspended/WorkspaceSuspended.tsx:64
  • Draft comment:
    Updated license state check from PAYMENT_FAILED to DEFAULTED; confirm that this behavior correctly detects suspension state.
  • Reason this comment was not posted:
    Marked as duplicate.
6. frontend/src/types/api/licensesV3/getActive.ts:2
  • Draft comment:
    Enums updated to reflect new license events and states; ensure that consumers of these enums are updated accordingly.
  • Reason this comment was not posted:
    Marked as duplicate.
7. ee/query-service/model/license.go:142
  • Draft comment:
    The conditional comment still mentions "inactive" but now checks for INVALID. Update the comment to reflect the new nomenclature.
  • Reason this comment was not posted:
    Marked as duplicate.
8. ee/query-service/model/plans.go:24
  • Draft comment:
    Renamed LicenseStatusInactive to LicenseStatusInvalid. Ensure that all references to the old constant are updated and that any descriptive comments align with this change.
  • Reason this comment was not posted:
    Marked as duplicate.
9. frontend/src/AppRoutes/Private.tsx:159
  • Draft comment:
    Updated check from LicenseState.PAYMENT_FAILED to LicenseState.DEFAULTED. Confirm that this new state aligns with the intended license logic.
  • Reason this comment was not posted:
    Marked as duplicate.
10. frontend/src/container/AppLayout/index.tsx:253
  • Draft comment:
    License event check updated to LicenseEvent.DEFAULT; ensure backend and frontend logic now consistently interpret this event.
  • Reason this comment was not posted:
    Marked as duplicate.
11. frontend/src/pages/WorkspaceSuspended/WorkspaceSuspended.tsx:63
  • Draft comment:
    The state check is updated to LicenseState.DEFAULTED. Verify that this correctly reflects the intended workspace suspension logic.
  • Reason this comment was not posted:
    Marked as duplicate.
12. frontend/src/types/api/licensesV3/getActive.ts:2
  • Draft comment:
    Enums updated to use DEFAULT (event) and DEFAULTED (state). Ensure documentation or comments clarify these changes if needed.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_SqJpi42RuJrJohIa


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@vikrantgupta25 vikrantgupta25 merged commit e414215 into main Feb 4, 2025
17 of 18 checks passed
@vikrantgupta25 vikrantgupta25 deleted the chore/update-license-state-events branch February 4, 2025 08:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants