Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix condition token inheritance #2240

Merged

Conversation

Entropy0
Copy link
Contributor

@Entropy0 Entropy0 commented Nov 9, 2021

Without this fix, isinstance(ConditionOR(), ConditionAND) yields True which is obviously not what one would expect

Without this fix, isinstance(ConditionOR(), ConditionAND) yields True
@frack113 frack113 requested a review from thomaspatzke November 9, 2021 13:08
@thomaspatzke thomaspatzke merged commit ad647a6 into SigmaHQ:master Nov 15, 2021
@Entropy0 Entropy0 deleted the bugfix/condition-type-inheritance branch November 29, 2021 15:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants