Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feature: source filtering #50

Merged
merged 1 commit into from
May 26, 2020
Merged

feature: source filtering #50

merged 1 commit into from
May 26, 2020

Conversation

tkurki
Copy link
Member

@tkurki tkurki commented May 25, 2020

This adds new configuration fields, one text field per source
path, where you can specify the source reference that should
match for the input data to trigger the conversion. Blank
value means no filtering.

At the same time this documents what SK paths each conversion is
using as source data.

This adds new configuration fields, one text field per source
path, where you can specify the source reference that should
match for the input data to trigger the conversion. Blank
value means no filtering.

At the same time this documents what SK paths each conversion is
using as source data.
@tkurki
Copy link
Member Author

tkurki commented May 25, 2020

A test failure on my machine, need to fix that.

@tkurki tkurki requested a review from sbender9 May 25, 2020 20:49
Copy link
Member

@sbender9 sbender9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and I tested it. Tests were already failing. Is it still WIP?

@tkurki
Copy link
Member Author

tkurki commented May 26, 2020

Was WIP only because I noticed the test problem after opening the PR, not really.

@tkurki tkurki changed the title [WIP] feature: source filtering feature: source filtering May 26, 2020
@sbender9 sbender9 merged commit 6d868dd into master May 26, 2020
@sbender9 sbender9 deleted the feature-source-filter branch May 26, 2020 14:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants