Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feature: add support for navigation data (129283, 129284) #54

Merged
merged 1 commit into from
Aug 8, 2021

Conversation

ardbiesheuvel
Copy link

Add support for emitting the various PGNs that carry the information
about the distance and bearing to the active waypoint. This should
provide all information needed by autopilots (heading to steer, XTE)
as well as bearing/distance to waypoint and estimated time of arrival,
which is commonly displayed for human consumption.

Tested with OpenCPN as the producer of APB sentences, and a B&G Triton2
display to show the various data items.

This is based on the outdated and incomplete implementation that lives
on the 'autopilot' branch.

Signed-off-by: Ard Biesheuvel ardb@kernel.org

Copy link
Member

@tkurki tkurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late reply.

Something that I'd like to have added is timeouts for the individual inputs. Timeouts are defined as an array in property named timeouts, with the order corresponding to the paths in keys. While today all the input data is coming as a single batch from nmea0183 input this may not be so in the future: some input paths may get updated, and some not, and output should be generated based on stale input values.

Copy link
Member

@tkurki tkurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also if you rebase on master the pesky test failure for the single unit test we have :-( should go away.

@ardbiesheuvel
Copy link
Author

Apologies for the late reply.

Something that I'd like to have added is timeouts for the individual inputs. Timeouts are defined as an array in property named timeouts, with the order corresponding to the paths in keys. While today all the input data is coming as a single batch from nmea0183 input this may not be so in the future: some input paths may get updated, and some not, and output should be generated based on stale input values.

Thanks for the pointers.

I am going to drop the 127237 sentence, by the way. It is currently incorrect, not trivial to implement, and both my Triton2 display as well as my NAC-3 autopilot computer are perfectly happy without it. It seems to me like this is more intended for course computer to display/actuator communication rather than GPS to instruments.

Add support for emitting the PGNs that carry the information about the
distance and bearing to the active waypoint. This should provide all
information needed by autopilots (heading to steer, XTE) as well as
bearing/distance to waypoint and estimated time of arrival, which is
commonly displayed for human consumption.

Tested with OpenCPN as the producer of APB sentences, and a B&G Triton2
display to show the various data items, as well as a NAC-3 course computer
which happily used the data to operate in Navigation mode.

This is based on the outdated and incomplete implementation that lives
on the 'autopilot' branch.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
@tkurki tkurki changed the title feature: add support for navigation data (127237, 129283, 129284) feature: add support for navigation data (129283, 129284) Aug 8, 2021
@tkurki tkurki merged commit 224d858 into SignalK:master Aug 8, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants