-
Notifications
You must be signed in to change notification settings - Fork 44.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ci(agent): Matrix CI tests across Linux, macOS and Windows #7029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7029 +/- ##
==========================================
- Coverage 45.33% 44.91% -0.43%
==========================================
Files 139 139
Lines 6511 6514 +3
Branches 912 915 +3
==========================================
- Hits 2952 2926 -26
- Misses 3408 3439 +31
+ Partials 151 149 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
Pwuts
force-pushed
the
ci-test/cross-platform-autogpt-ci
branch
from
March 20, 2024 10:19
542a1ff
to
08a2aa2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
✅ Deploy Preview for auto-gpt-docs canceled.
|
Pwuts
force-pushed
the
ci-test/cross-platform-autogpt-ci
branch
from
March 20, 2024 10:32
08a2aa2
to
374d9a0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Pwuts
force-pushed
the
ci-test/cross-platform-autogpt-ci
branch
from
March 20, 2024 15:55
7bb8e6b
to
57bf4e2
Compare
Pwuts
force-pushed
the
ci-test/cross-platform-autogpt-ci
branch
from
March 20, 2024 16:45
59ea2c5
to
e3155bd
Compare
Pwuts
force-pushed
the
ci-test/cross-platform-autogpt-ci
branch
from
March 20, 2024 16:59
a270657
to
8921cfc
Compare
9 tasks
Pwuts
force-pushed
the
ci-test/cross-platform-autogpt-ci
branch
20 times, most recently
from
March 21, 2024 10:34
13ebfc4
to
a7d397c
Compare
Pwuts
force-pushed
the
ci-test/cross-platform-autogpt-ci
branch
from
March 21, 2024 10:41
a7d397c
to
84fcc58
Compare
ntindle
approved these changes
Mar 21, 2024
Pwuts
changed the title
ci(agent): Add Windows and macOS test jobs
ci(agent): Matrix CI tests across Linux, macOS and Windows
Mar 21, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to support certain platforms, we need to include them in our automated tests. Currently, all of our CI runs on Linux (
ubuntu-latest
), and so it's blind to platform specific issues with Windows or macOS.Triggered by this comment.
Changes 🏗️
Matrix the AutoGPT Python CI's
test
job across Ubuntu, macOS and WindowsSet up MinIO in a step rather than specifying it under
jobs[test].services
, because services are only supported on Linux runnersAdd Windows version of step to install Poetry
Add macOS compatibility patches to 'Install Poetry (Unix)' and
setup_git_auth
stepsCaveats:
No Docker on macOS or Windows
docker pull
that takes 2 seconds on Linux takes 45 seconds on macOS.No S3 service available on Windows
It seems that running a background process isn't possible on Windows, and neither is running Linux-based Docker containers.
Add
autogpt-agent
and OS-specific flags to Codecov upload stepImprove caching of Python dependencies by changing the cache key
poetry.lock
instead ofpyproject.toml
in keyrequirements.txt
. Withpoetry.lock
that is no longer a concern.Fix skip check in test_s3_file_storage.py
PR Quality Scorecard ✨
+2 pts
+5 pts
+5 pts
+5 pts
-4 pts
+4 pts
+5 pts
-5 pts
agbenchmark
to verify that these changes do not regress performance?+10 pts