Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support old version and new version of sourcebans++ #14

Closed
wants to merge 1 commit into from
Closed

Support old version and new version of sourcebans++ #14

wants to merge 1 commit into from

Conversation

Drmohammad11
Copy link

@Drmohammad11 Drmohammad11 commented Sep 30, 2019

i dont test this pull!!
please test !

@Silenci0
Copy link
Owner

Silenci0 commented Oct 1, 2019

Hello Drmohammad11,

As stated in the issue #13, I did not see this pull request until after I uploaded my changes. I am sorry that I did not notice this earlier, but I thank you for your work and you bringing this issue to my attention.

Since I already made the changes and uploaded them, I won't be merging your pull request with the repo, but just know that if I had seen this earlier I would have accepted it, though probably with a slight change to the order of the Native_Ban check to look for the new Sourcebans++ native first. I hope that this does not discourage future pull requests you or others might make to the repo.

Again, thank you for your work, it is appreciated!

Thank you,

Silence

@Silenci0 Silenci0 closed this Oct 1, 2019
@Drmohammad11 Drmohammad11 deleted the patch-1 branch October 1, 2019 05:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants