-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ZGW-3430: Add Z-Wave API serial logs #30
Open
lmolina
wants to merge
1
commit into
SiliconLabs:main
Choose a base branch
from
lmolina:task/lamolina/ZGW-3430-add-serial-log-decoder
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ZGW-3430: Add Z-Wave API serial logs #30
lmolina
wants to merge
1
commit into
SiliconLabs:main
from
lmolina:task/lamolina/ZGW-3430-add-serial-log-decoder
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7163435
to
c85882d
Compare
rzr
reviewed
Sep 16, 2024
rzr
reviewed
Sep 16, 2024
9899f2d
to
ea45531
Compare
Add a decoder to parse the SAPI logs generated by the Z/IP Gateway. The original script works on ZPC. This commit adapts the script to parse traces generated by the Z/IP Gateway. Original script available at https://github.com/SiliconLabs/UnifySDK/blob/ver_1.6.0/scripts/serial_decode_zpc.py
ea45531
to
a3d4a8a
Compare
rzr
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May this be reverted
lmolina
added a commit
to lmolina/UnifySDK
that referenced
this pull request
Dec 2, 2024
The Z/IP Gateway is reusing the script to parse SAPI logs. The script was adjusted to be compatible with the ZGW logs. Adding a reference to the ZGW copy on the original script. Related-to: SiliconLabs/zipgateway#30
1 task
What do you want to revert? |
If we want to slim it down to minimum, and do the maintenance at unify, to avoid divergence. |
I think this would be nice to have in z-w-p-c too |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a decoder to parse the SAPI logs generated by the Z/IP Gateway.
The original script works on ZPC. This commit adapts the script to parse traces generated by the Z/IP Gateway.
Original script available at https://github.com/SiliconLabs/UnifySDK/blob/main/scripts/serial_decode_zpc.py