SWPROT-9242: Move s2 protocol CC encryption handling to protocol CC #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasdjb
force-pushed
the
task/thdubois/nls-supervision
branch
from
dab27ba to
72ad3ac
Compare
Thomasdjb
added a commit
to Thomasdjb/z-wave-protocol-controller
that referenced
this pull request
Feb 18, 2025
- create a protocol command class handler that handle also protocol LR commands - add unit tests for this handler - remove request protocol cc encryption code from s2 and move it to new protocol cc - add supervision encapsulation of protocol cc Origin: SiliconLabsSoftware#43
Thomasdjb
force-pushed
the
task/thdubois/nls-supervision
branch
from
72ad3ac to
6957fed
Compare
|
May we merge this after the post releases changes that do not touch the code |
|
I see your branch is passing: https://github.com/Thomasdjb/z-wave-protocol-controller/tree/task/thdubois/nls-supervision See the green tick next to your commit, no regression. I will enable build in PR in upcoming PRs |
rzr
reviewed
Mar 4, 2025
There was a problem hiding this comment.
This change has been verified using the simulator:
https://github.com/Z-Wave-Alliance/z-wave-stack/wiki/ZPC#s2v2-example
May we merge other libs2 changes before this one.
|
To be merged after: |
rzr
force-pushed
the
task/thdubois/nls-supervision
branch
from
6957fed to
39c6d7c
Compare
rzr
pushed a commit
to Thomasdjb/z-wave-protocol-controller
that referenced
this pull request
Mar 7, 2025
- create a protocol command class handler that handle also protocol LR commands - add unit tests for this handler - remove request protocol cc encryption code from s2 and move it to new protocol cc - add supervision encapsulation of protocol cc Origin: SiliconLabsSoftware#43
rzr
reviewed
Mar 7, 2025
| zwave_tx_options_t tx_options = {0}; | ||
| uint8_t number_of_expected_responses = 1; | ||
| uint32_t discard_timeout_ms = 5000; | ||
| // sl_status_t ret = SL_STATUS_OK; |
There was a problem hiding this comment.
Suggested change
| // sl_status_t ret = SL_STATUS_OK; |
rzr
reviewed
Mar 7, 2025
| @@ -204,6 +204,7 @@ static uic_fixt_shutdown_step_t uic_fixt_shutdown_steps_list[] | |||
| {&dotdot_mapper_teardown, "DotDot mapper"}, | |||
| {NULL, "Terminator"}}; | |||
|
|
|||
|
|
|||
|
Can we merge this? |
we can, I wanted to fix tests before merging but since you are depending on it, it can be merged, arent you ? btw other reviews on open PR is also welcome |
silabs-aydogane
approved these changes
Mar 17, 2025
Thomasdjb
force-pushed
the
task/thdubois/nls-supervision
branch
from
39c6d7c to
f5ad612
Compare
Thomasdjb
added a commit
to Thomasdjb/z-wave-protocol-controller
that referenced
this pull request
Apr 22, 2025
- create a protocol command class handler that handle also protocol LR commands - add unit tests for this handler - remove request protocol cc encryption code from s2 and move it to new protocol cc - add supervision encapsulation of protocol cc Origin: SiliconLabsSoftware#43
rzr
force-pushed
the
main
branch
2 times, most recently
from
5486b41 to
78dfbc4
Compare
Thomasdjb
added a commit
to Thomasdjb/z-wave-protocol-controller
that referenced
this pull request
Apr 23, 2025
- create a protocol command class handler that handle also protocol LR commands - add unit tests for this handler - remove request protocol cc encryption code from s2 and move it to new protocol cc - add supervision encapsulation of protocol cc Origin: SiliconLabsSoftware#43
Thomasdjb
force-pushed
the
task/thdubois/nls-supervision
branch
from
f5ad612 to
4d6839a
Compare
- create a protocol command class handler that handle also protocol LR commands - add unit tests for this handler - remove request protocol cc encryption code from s2 and move it to new protocol cc - add supervision encapsulation of protocol cc Origin: SiliconLabsSoftware#43
Thomasdjb
force-pushed
the
task/thdubois/nls-supervision
branch
from
4d6839a to
72b17e7
Compare
rzr
approved these changes
Apr 23, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Checklist