Skip to content

add CLI interface for setting priority route #96

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add CLI interface for setting priority route #96

wants to merge 1 commit into from

Conversation

lmolina
Copy link
Collaborator

@lmolina lmolina commented May 14, 2025

Enables the use of the CLI to set the priority route, as defined in the Z-Wave Host API Specification 4.4.3.14.

Related-to: UIC-3657

Change

Checklist

@lmolina lmolina requested a review from silabs-aydogane May 14, 2025 13:27
rzr
rzr reviewed May 14, 2025
View reviewed changes
Copy link
Collaborator

@rzr rzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good, side remark did you use clang-format ? I am asking because check is not done by CI, I should enable this sooner than later

lmolina added a commit that referenced this pull request May 14, 2025
@lmolina
UIC-3657: add CLI interface for setting priority route
d3004b3 
Enables the use of the CLI to set the priority route, as defined in the
Z-Wave Host API Specification 4.4.3.14.

Origin: #96
@lmolina lmolina force-pushed the task/lamolina/UIC-3657-ZPC-Implement-Set-Priority-Route branch from ec4c999 to d3004b3 Compare May 14, 2025 14:22
lmolina added a commit that referenced this pull request May 14, 2025
@lmolina
UIC-3657: add CLI interface for setting priority route
5c13030 
Enables the use of the CLI to set the priority route, as defined in the
Z-Wave Host API Specification 4.4.3.14.

Origin: #96
@lmolina lmolina force-pushed the task/lamolina/UIC-3657-ZPC-Implement-Set-Priority-Route branch from d3004b3 to 5c13030 Compare May 14, 2025 14:40
rzr pushed a commit that referenced this pull request May 15, 2025
@lmolina @rzr
UIC-3657: add CLI interface for setting priority route
e83357c 
Enables the use of the CLI to set the priority route, as defined in the
Z-Wave Host API Specification 4.4.3.14.

Origin: #96
@rzr rzr force-pushed the task/lamolina/UIC-3657-ZPC-Implement-Set-Priority-Route branch from 5c13030 to e83357c Compare May 15, 2025 15:39
@rzr
Copy link
Collaborator

rzr commented May 15, 2025 •
edited
Loading

I rebased to trigger tests:

https://github.com/SiliconLabsSoftware/z-wave-protocol-controller/actions/runs/15049657506 it is passing (for some reason it does not show up in the PR)

May you update the commit message to explain how this was tested.

lmolina added a commit that referenced this pull request May 19, 2025
@lmolina
UIC-3657: add CLI interface for setting priority route
819e846 
Enables the use of the CLI to set the priority route, as defined in the
Z-Wave Host API Specification 4.4.3.14.

Origin: #96
@lmolina lmolina force-pushed the task/lamolina/UIC-3657-ZPC-Implement-Set-Priority-Route branch from e83357c to 819e846 Compare May 19, 2025 09:57
@lmolina
Copy link
Collaborator Author

lmolina commented May 19, 2025

Updated the PR to fix style (use clang-format-17).

@lmolina
Copy link
Collaborator Author

lmolina commented May 19, 2025

May you update the commit message to explain how this was tested.

What do you mean by how it was tested? Only a few ad-hoc/manual tests + the new unit tests. What's the process/flow for the project?

lmolina added a commit that referenced this pull request May 19, 2025
@lmolina
UIC-3657: add CLI interface for setting priority route
1b605b2 
Enables the use of the CLI to set the priority route, as defined in the
Z-Wave Host API Specification 4.4.3.14.

Origin: #96
@lmolina lmolina force-pushed the task/lamolina/UIC-3657-ZPC-Implement-Set-Priority-Route branch from 819e846 to 1b605b2 Compare May 19, 2025 10:56
lmolina added a commit that referenced this pull request May 21, 2025
@lmolina
UIC-3657: add CLI interface for setting priority route
04e3289 
Enables the use of the CLI to set the priority route, as defined in the
Z-Wave Host API Specification 4.4.3.14.

Origin: #96
@lmolina lmolina force-pushed the task/lamolina/UIC-3657-ZPC-Implement-Set-Priority-Route branch from 1b605b2 to 04e3289 Compare May 21, 2025 14:01
lmolina added a commit that referenced this pull request May 22, 2025
@lmolina
UIC-3657: add CLI interface for setting priority route
c13aff0 
Enables the use of the CLI to set the priority route, as defined in the
Z-Wave Host API Specification 4.4.3.14.

Origin: #96
@lmolina lmolina force-pushed the task/lamolina/UIC-3657-ZPC-Implement-Set-Priority-Route branch from 04e3289 to c13aff0 Compare May 22, 2025 12:34
lmolina added a commit that referenced this pull request May 22, 2025
@lmolina
UIC-3657: add CLI interface for setting priority route
d19e676 
Enables the use of the CLI to set the priority route, as defined in the
Z-Wave Host API Specification 4.4.3.14.

Origin: #96
@lmolina lmolina force-pushed the task/lamolina/UIC-3657-ZPC-Implement-Set-Priority-Route branch from c13aff0 to d19e676 Compare May 22, 2025 12:46
@rzr
Copy link
Collaborator

rzr commented May 22, 2025 •
edited
Loading

I see it was tested with:
https://github.com/SiliconLabsSoftware/z-wave-protocol-controller/actions/runs/15187329487

May you:

Update:

I made a test on my fork, to check if everything still build after ci changes:
https://github.com/rzr/z-wave-protocol-controller/releases/tag/ver_1.7.0-91-gd19e676a6

Testables assets (are not published on purpose) but can be downloaded from:

https://github.com/rzr/z-wave-protocol-controller/actions/runs/15189766930/job/42751498166

Artifact z-wave-protocol-controller-ver_1.7.0-91-gd19e676a6-amd64.zip successfully finalized. Artifact ID 3181745132
Artifact z-wave-protocol-controller-ver_1.7.0-91-gd19e676a6-amd64 has been successfully uploaded! Final size is 155170383 bytes. Artifact ID is 3181745132
Artifact download URL: https://github.com/rzr/z-wave-protocol-controller/actions/runs/15189766930/artifacts/3181745132

@lmolina lmolina requested a review from rzr May 23, 2025 12:24
lmolina added a commit that referenced this pull request May 23, 2025
@lmolina
UIC-3657: add CLI interface for setting priority route
0c541a6 
Enables the use of the CLI to set the priority route, as defined in the
Z-Wave Host API Specification 4.4.3.14.

Origin: #96
@lmolina lmolina force-pushed the task/lamolina/UIC-3657-ZPC-Implement-Set-Priority-Route branch from d19e676 to 0c541a6 Compare May 23, 2025 12:41
@rzr
Copy link
Collaborator

rzr commented May 23, 2025 •
edited
Loading

This zwave_command_class_user_code_test failing test is sporadic

It would help to get it fixed in other PR

#110

I think I have found the cause i am testing it, and then we can merge

rzr pushed a commit that referenced this pull request May 28, 2025
@lmolina @rzr
UIC-3657: add CLI interface for setting priority route
ee3c6b9 
Enables the use of the CLI to set the priority route, as defined in the
Z-Wave Host API Specification 4.4.3.14.

Origin: #96
@rzr rzr force-pushed the task/lamolina/UIC-3657-ZPC-Implement-Set-Priority-Route branch from 0c541a6 to ee3c6b9 Compare May 28, 2025 14:00
@rzr
Copy link
Collaborator

rzr commented May 30, 2025

Btw here are testable for RPI:

https://github.com/rzr/z-wave-protocol-controller/actions/runs/15189766930/artifacts/3179431411

rzr pushed a commit that referenced this pull request May 30, 2025
@lmolina @rzr
UIC-3657: add CLI interface for setting priority route
3900056 
Enables the use of the CLI to set the priority route, as defined in the
Z-Wave Host API Specification 4.4.3.14.

Origin: #96
@rzr rzr force-pushed the task/lamolina/UIC-3657-ZPC-Implement-Set-Priority-Route branch from ee3c6b9 to 3900056 Compare May 30, 2025 14:58
lmolina added a commit that referenced this pull request Jun 2, 2025
@lmolina
UIC-3657: add CLI interface for setting priority route
838c449 
Enables the use of the CLI to set the priority route, as defined in the
Z-Wave Host API Specification 4.4.3.14.

Origin: #96
@lmolina lmolina force-pushed the task/lamolina/UIC-3657-ZPC-Implement-Set-Priority-Route branch from 3900056 to 838c449 Compare June 2, 2025 13:19
@lmolina
Copy link
Collaborator Author

lmolina commented Jun 2, 2025

@rzr now that tests are fixed. Is this ready for merge?

@rzr
Copy link
Collaborator

rzr commented Jun 2, 2025

@rzr now that tests are fixed. Is this ready for merge?

yes, may other sec fixes merged before to have them grouped but if hurry we can merge it now,

meanwhile any testers feedback ?

@lmolina @rzr
UIC-3657: add CLI interface for setting priority route
27036ba 
Enables the use of the CLI to set the priority route, as defined in the
Z-Wave Host API Specification 4.4.3.14.

Origin: #96
@rzr rzr force-pushed the task/lamolina/UIC-3657-ZPC-Implement-Set-Priority-Route branch from 838c449 to 27036ba Compare June 3, 2025 13:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Thomasdjb Thomasdjb Thomasdjb approved these changes

@silabs-aydogane silabs-aydogane Awaiting requested review from silabs-aydogane

@rzr rzr Awaiting requested review from rzr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmolina @rzr @Thomasdjb