Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Text Style on Flutter 3.22 #433

Conversation

chandrabezzo
Copy link
Contributor

@chandrabezzo chandrabezzo commented May 14, 2024

Description

After Flutter SDK 3.22, removed deprecated text theme for headline6 and subtitle2. To fix this issue I follow migration guide from here.

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issue

#434

Result

Screenshot 2024-05-14 at 09 07 13

Follow Migration Guide
Screenshot 2024-05-15 at 08 19 08

@chandrabezzo chandrabezzo changed the title Fix Text Style on Flutter 3.22 fix: Text Style on Flutter 3.22 May 14, 2024
@VB10
Copy link

VB10 commented May 14, 2024

lgtm 🌸

here is an example of usage this pr:

 showcaseview: 
    git: 
      url: https://github.com/chandrabezzo/flutter_showcaseview
      ref: bugfix/text-theme/removed-3.22

Copy link

@ashu3699 ashu3699 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add this..

@aditya-css
Copy link
Collaborator

Hello @chandrabezzo, Thank you for raising this PR. Can you please bump the version to 3.0.0 pubspec and changelog?

example/android/app/build.gradle Outdated Show resolved Hide resolved
pubspec.yaml Outdated Show resolved Hide resolved
@chandrabezzo
Copy link
Contributor Author

Done @aditya-css

@aditya-css aditya-css merged commit 5529c5d into SimformSolutionsPvtLtd:master May 31, 2024
2 checks passed
@Obada2020
Copy link

how to pull this in my git

@victor337
Copy link

how to pull this in my git

I think he will update in pub.dev, but in the meantime use this:

showcaseview:
    git:
      url: https://github.com/chandrabezzo/flutter_showcaseview
      ref: ae8d8a327cdede529d264d1df02892fdc6161688

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.