[BUG FIX] [MER-3797] Fix Youtube XAPI emitting #5099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliknebel
reviewed
Sep 12, 2024
| @@ -22,6 +22,8 @@ defmodule OliWeb.Api.XAPIController do | |||
|
|
|||
| {:error, e} -> | |||
| Logger.error("Error constructing xapi bundle: #{inspect(e)}") | |||
| Oli.Utils.Appsignal.capture_error("Error constructing xapi bundle: #{inspect(e)}") | |||
There was a problem hiding this comment.
It seems like there should be some way to notify AppSignal any time Logger.error is called, so that we don't need to explicitly call it separately. But that is something we can maybe explore in a non-hotfix release
eliknebel
approved these changes
Sep 12, 2024
eliknebel
added a commit
that referenced
this pull request
Sep 24, 2024
* delay submission to ensure all save state calls have finished * set version * reduce deferred period * disable all activity inputs * Auto format * [BUG FIX] [MER-3775] Allow embedded page links to open (#5092) * account for unordered pages * use page_context instead of current_page * [CHORE] [MER-3786] allow setting of the interval and target for db_connection (#5093) * [BUG FIX] [MER-3797] Fix Youtube XAPI emitting (#5099) * directly provide atempt guid * Auto format --------- Co-authored-by: darrensiegel <darrensiegel@users.noreply.github.com> * bump version number * bump version number * [BUG FIX] [MER-3823] Convert numeric to text input (#5109) * convert numeric to text input * cleanup * Auto format * change regex to allow 300. and .300 as valid numbers * allow same numbers in answer authoring as in delivery --------- Co-authored-by: darrensiegel <darrensiegel@users.noreply.github.com> Co-authored-by: Anders Weinstein <andersw@cs.cmu.edu> * [BUG FIX] [MER-3619] Fix an issue where account creation silently fails in certain cases (#5108) * fix an issue where account creation was not properly filtering out LTI accounts * remove redundant clause * Auto format --------- Co-authored-by: eliknebel <eliknebel@users.noreply.github.com> * fix pow_test * fix formatting --------- Co-authored-by: Darren Siegel <siegel.darren@gmail.com> Co-authored-by: darrensiegel <darrensiegel@users.noreply.github.com> Co-authored-by: Anders Weinstein <andersw@cs.cmu.edu> Co-authored-by: eliknebel <eliknebel@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Youtube video was present in the page (as opposed to being in an activity) it was NOT correctly emitting XAPI events from the front end for play, pause, stop, etc. It was missing the page attempt guid, which broke the bundle creation on the server and prevented the XAPI bundle from going to S3.
This PR fixes the problem by mirroring the solution present for HTML5 video (which does work), namely to simply specify and pass down the attempt guid as a React param.