Fix Detailed Versions #7945
Merged
Fix Detailed Versions #7945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdarwood007
added
Housekeeping
live627
reviewed
Dec 6, 2023
Sesquipedalian
approved these changes
Dec 24, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues needed to get detailed versions to work correctly.
I've done a change to include a 'root' directory that will hold the cron, subscriptions, ssi, proxy, and any future files at the root of the forum.
To support sources, I changed over to a iterator for sources. Made things a bit easier actually. I can do this for the rest if we want.
There is a related PR on the build tools: SimpleMachines/BuildTools#28
SimpleMachines website is updated with that content at the moment.
When the build tool PR merges, this pr can be updated to reference the updated BuildTools repo and then merged. Or that can be updated any time after as long as its updated before the alpha release.