Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

The "(no primary membergroup)" option was missing when editing profiles #7948

Merged

Conversation

Oldiesmann
Copy link
Contributor

The "(no primary membergroup)" option was missing from the profile, preventing you from being able to remove a member's primary group. I discovered this while trying to demote a test account from administrator to a regular user.

Signed-off-by: Michael Eshom <oldiesmann@gmail.com>
Copy link
Member

@Sesquipedalian Sesquipedalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved comment seems to be a mistake. Otherwise, looks good.

@Oldiesmann
Copy link
Contributor Author

Not sure how that happened. I'll fix it when I get home tonight 🙂

Signed-off-by: Michael Eshom <oldiesmann@gmail.com>
Signed-off-by: Michael Eshom <oldiesmann@gmail.com>
@jdarwood007
Copy link
Member

PHP check is failing because of lint failure. Nothing introduced by this PR far as I can tell.

@Sesquipedalian Sesquipedalian merged commit 5493f5a into SimpleMachines:release-3.0 Dec 22, 2023
2 of 3 checks passed
@Oldiesmann Oldiesmann deleted the fix_group_membership branch December 23, 2023 02:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants