-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[3.0] Password improvements #8464
[3.0] Password improvements #8464
Conversation
Sesquipedalian
commented
Feb 11, 2025
- As per internal discussion, we no longer prefix the username to the password in SMF\Security::hashPassword().
- Moves various functions for generating and validating passwords and authentication codes into SMF\Security.
- Modernizes our password strength checks by using zxcvbn instead of discredited old rules that require passwords to contain certain characters.
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
I tried to change my own password in my profile and get this error:
|
Derp. I will push a fix for that soon. |
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
b5dd454
to
04483c5
Compare
Fixed |
One more reason to use composer #8240 |
So, a scenario I have here is that I logged into my admin account and loaded up this PR. I refreshed the page, and nothing changed, and was still logged in. I couldn't go into the ACP because I failed to authenticate into that. Shouldn't this trigger a failure due to the hashed password in the cookie no longer being valid? |
Do you have caching enabled? If so, the cached value for your user profile data would still include the old password hash, which would in turn mean that the password hash in the cookie data would still match when checked by User::verifyPassword() during page load. I don't believe this will be an issue except during the period of time when we are testing this PR. It is only happening now because there is no way for the cache to be aware that you've changed which Git branch you happen to have checked out. Once the PR has been merged, the possibility for a mismatch between the cached password hash and the real password hash will disappear. In the meantime, just disable caching while testing this PR. Once the PR has been merged, you can turn caching back on. |
I do not. If thats not a concern, then this is all ready go to. |