🎨 Fix afterOptimizeChunkAssets deprecation warning #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ryanatlascreative
commented
Jul 11, 2021
ryanatlascreative
commented
- Remove legacy code and ran Prettier to clean the codebase. Fixes deprecation warning relating to afterOptimizeChunkAssets.
ryanatlascreative
added
type: bug
rushilsrivastava
requested changes
Jul 12, 2021
Sweet, will get on this now! |
Comment on lines
+15
to
+27
| return this._compiler.hooks.compilation.tap( | ||
| CompilerEventsFacade.extensionName, | ||
| (comp) => { | ||
| const afterOptimizeChunkAssets = (chunks) => { | ||
| call(comp, chunks); | ||
| }; | ||
| /* https://github.com/webpack/webpack/blob/main/lib/Compilation.js#L772-L779 | ||
| afterOptimizeChunkAssets = PROCESS_ASSETS_STAGE_OPTIMIZE + 1 | ||
| */ | ||
| const stage = Compilation.PROCESS_ASSETS_STAGE_OPTIMIZE + 1; | ||
| (comp.hooks as any).processAssets.tap( | ||
| { name: CompilerEventsFacade.extensionName, stage }, | ||
| afterOptimizeChunkAssets, |
There was a problem hiding this comment.
Let's release this as a minor patch, and work on refactoring this to use the new processAssets and release that as a major patch.
rushilsrivastava
approved these changes
Jul 13, 2021
6 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.