Added Meta for Pages csproj #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing metadata to the Pages csproj file in order to ensure that the Pages package generates with the proper information.
- Added a PropertyGroup block with Product and Description elements
- Provides required metadata for the Pages assembly
Comments suppressed due to low confidence (1)
src/Sitecore.AspNetCore.SDK.Pages/Sitecore.AspNetCore.SDK.Pages.csproj:4
- Consider updating the product name to 'Sitecore ASP.NET Core SDK Pages' to follow the standard .NET naming conventions.
<Product>Sitecore ASP.Net Core SDK Pages</Product>
src/Sitecore.AspNetCore.SDK.Pages/Sitecore.AspNetCore.SDK.Pages.csproj
Outdated
Show resolved
Hide resolved
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing metadata for Pages Assembly
Description / Motivation
The Pages package wasn't generating with any information, due to the missing meta data in the csproj
Testing
Terms