-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add a method to disable a hook's registration #4093
Add a method to disable a hook's registration #4093
Conversation
Do you think it would be useful to throw an exception if we use the |
Possibly. This method will only be used in very specific cases so I am not sure if it's all too necessary as the developer should know what they're doing when using the method. I am open to hearing other thoughts on this too though. |
I think it'd be a good idea to throw an exception in that case: if an addon developer incorrectly uses the method (e.g. in |
what about adding a corresponding option to the config? I think this is something that could be useful to expose to users too |
Added. Please let me know if the config stuff is wrong as I haven't added any config options before. It did work when I tested it though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me 👍
Description
This PR adds a method to disable a hook's registration. This is mainly for addon developers looking to disable a hook.
This could be useful in the case of: skript-worldguard
Target Minecraft Versions: Any
Requirements: None
Related Issues: None