Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove reload memory leak preventing code #4101

Merged

Conversation

TPGamesNL
Copy link
Member

Description

Removes the code in Skript#onDisable that is supposed to prevent memory leaks when using the /reload command, but it gave more problems than it solved.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@TPGamesNL TPGamesNL added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jun 22, 2021
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@ShaneBeee ShaneBeee merged commit 477c85b into SkriptLang:master Jun 22, 2021
@TPGamesNL TPGamesNL deleted the enhancement/remove-reload-support branch June 22, 2021 17:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants