Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 'return null' here caused the parser to stop after the first match, even if the expression parsing failed.
For example, matching
loop-value-1-1
against%number%-%number%
has the first match of(loop-value)-(1-1)
, because that matches the pattern. However, if parsing the expressionloop-value
does not work, the parser is supposed to attempt(loop-value-1)-(1)
, because that also matches the pattern. Because of the return statement here, it doesn't do this.The main problem with this change, is that it increases parsing time by about 17% from my tests.
Target Minecraft Versions: any
Requirements: none
Related Issues: #2382