-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Player Statistics #7568
base: dev/feature
Are you sure you want to change the base?
Player Statistics #7568
Conversation
src/main/java/ch/njol/skript/events/EvtPlayerStatisticIncrease.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprNewStatisticValue.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprPlayerStatistics.java
Outdated
Show resolved
Hide resolved
|
||
static { | ||
Skript.registerEvent("Player Statistic Increase", EvtPlayerStatisticIncrease.class, PlayerStatisticIncrementEvent.class, | ||
"player statistic increase [of %*-strings%]") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"player statistic increase [of %*-strings%]") | |
"player statistic increase [of %-strings%]") |
Just realized after looking in skriptlang-development
But you dont need the *
(literal identifier) here because it can only ever be a literal.
|
||
static { | ||
Skript.registerEvent("Player Statistic Increase", EvtPlayerStatisticIncrease.class, PlayerStatisticIncrementEvent.class, | ||
"player statistic increase [of %*-strings%]") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"player statistic increase [of %*-strings%]") | |
"player statistic (increase|increment) [of %*-strings%]") |
I think the strings should be parsed into actual Statistics whenever possible, for faster comparison and to allow proper errors. |
Description
This PR aims to add player statistics and closes the beloved and old issue #4687! Here's a slight glimpse of how statistics will look like:
Target Minecraft Versions: any
Requirements: none
Related Issues: #4687