Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Aliases Update for Minecraft 1.17 #69

Merged
merged 3 commits into from
Jun 16, 2021
Merged

Aliases Update for Minecraft 1.17 #69

merged 3 commits into from
Jun 16, 2021

Conversation

APickledWalrus
Copy link
Member

This PR aims to add aliases for then new blocks and items added into Minecraft 1.17

I used the wiki along with a lovely document Shane gave me for reference (thanks!) to try and get everything.
However, it is possible I still missed some things so if anyone wants to double check I would appreciate it.
It is also possible I made some mistakes, as there were a lot of new blocks to cover.

Copy link
Member

@TheBentoBox TheBentoBox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff man, a few small issues

decoration.sk Outdated Show resolved Hide resolved
decoration.sk Outdated Show resolved Hide resolved
misc.sk Outdated Show resolved Hide resolved
other.sk Outdated Show resolved Hide resolved
@APickledWalrus
Copy link
Member Author

Need to make some changes as aliases will not currently load on 1.17 correctly

@APickledWalrus
Copy link
Member Author

🎆 With this third pass, the aliases all successfully load on 1.17 (tested with debug mode on and stuff) 🥳

I think this PR is good to go now - but one final look from someone to make sure the name patterns for everything is good wouldn't hurt.

Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ShaneBeee ShaneBeee merged commit f14d969 into SkriptLang:master Jun 16, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants