fix unbounded variable bug in observer service

[wintonzheng]

Important

Fix unbounded variable bug in initialize_observer_task() by correcting workflow_run_id and updating database reference.

• Bug Fixes:
  • Correct workflow_run_id parameter in mark_observer_task_as_failed() in initialize_observer_task().
  • Change app.DATABASE to app.database in initialize_observer_task() for update_observer_cruise() call.

^{This description was created by for 19c88d4. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 19c88d4 in 1 minute and 57 seconds

More details

• Looked at 22 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. skyvern/forge/sdk/services/observer_service.py:168

• Draft comment:
  Changed workflow_run_id from workflow_run.workflow_run_id to observer_task.workflow_run_id. Ensure this is the intended fix for the unbounded variable bug.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50%
  The comment is asking the author to verify their fix for an "unbounded variable bug". However, this change appears to be a clear bug fix - if workflow_run creation fails, workflow_run would be undefined, so we need to use observer_task.workflow_run_id instead. The comment is just asking for confirmation of something that is obviously correct.
  Could there be some important context about the unbounded variable bug that I'm missing? Maybe there's a reason to be cautious about this change?
  No - this is a straightforward fix for a case where workflow_run fails to be created. Using observer_task.workflow_run_id is clearly correct since we need a workflow_run_id even in the error case.
  Delete the comment. The change is a clear bug fix and doesn't need verification - if workflow_run creation fails, we need to use observer_task.workflow_run_id instead of the undefined workflow_run variable.

2. skyvern/forge/sdk/services/observer_service.py:190

• Draft comment:
  Changed app.DATABASE.update_observer_cruise to app.database.update_observer_cruise. Verify consistency and naming across the project.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  The comment is asking the author to verify consistency and naming across the project, which is not allowed according to the rules. It doesn't provide a specific suggestion or point out a specific issue with the code change itself.

3. skyvern/forge/sdk/services/observer_service.py:168

• Draft comment:
  Use of observer_task.workflow_run_id avoids reference to an unbound workflow_run if workflow_run isn’t initialized. Confirm this is the correct identifier.
• Reason this comment was not posted:
  Marked as duplicate.

4. skyvern/forge/sdk/services/observer_service.py:189

• Draft comment:
  Updated call to update_observer_cruise now uses app.database instead of app.DATABASE; verify that this naming change is intentional and consistent.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_lyNA2jbn3tz7AoLw

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.