Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MHubRunner Extension in Slicer 5.8 #2140

Merged
merged 5 commits into from
Feb 12, 2025
Merged

MHubRunner Extension in Slicer 5.8 #2140

merged 5 commits into from
Feb 12, 2025

Conversation

LennyN95
Copy link
Contributor

The Extension has been merged to main in #2137 already - can we merge it into 3.8 too?
Thank you!

@LennyN95 LennyN95 marked this pull request as ready for review January 30, 2025 10:16
@LennyN95
Copy link
Contributor Author

@jcfr The GH action fails with the following error, is there something I need to change on my end?
@fedorov tried to re-run the workflow but without success.

  FailedFileLoadError: Failed to parse https://raw.githubusercontent.com/Slicer/Slicer/main/Schemas/slicer-extension-catalog-entry-schema-v1.0.1.json
    in "/home/runner/.cache/pre-commit/repo6epn1q6v/py_env-python3.9/lib/python3.9/site-packages/check_jsonschema/schema_loader/readers.py", line 27

The code is no different from what we pushed into the main branch and is available in the nightly version.
Thank you!

Copy link
Contributor

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The json schema check is unstable for some reason. Anyway, the file content is correct now and the check passed, so it is good to go.

@lassoan lassoan merged commit cb2cbcd into Slicer:5.8 Feb 12, 2025
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants