Use tcp_close to destroy the TCP listening socket. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's an error to call tcp_poll() on a pcb that has been converted to a listening socket via tcp_listen(), with such calls causing memory corruption. Call tcp_close to destroy the socket instead in ~TcpServer, and NULL out tcp to suppress the call to tcp_poll in the base class (via ~TcpConnection()->TcpConnection::close()->tcp_poll()).
|
@alltheblinkythings : |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an error to call tcp_poll() on a pcb that has been converted to a
listening socket via tcp_listen(), with such calls causing memory corruption.
Call tcp_close to destroy the socket instead in ~TcpServer, and NULL out tcp
to suppress the call to tcp_poll in the base class
(via ~TcpConnection()->TcpConnection::close()->tcp_poll()).