-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
WIP Update egui to 0.24 #16
base: main
Are you sure you want to change the base?
Conversation
I guess we can try to change this to an Rc in smithay and see if something breaks. Theoretically these contexts are thread-safe, as long as they are not current in multiple threads. Worst case, if both are not an option, would be to create a shared context for egui... |
Seems they have fixed this after the 0.13 release... sigh Maybe we can convince egui to change that back, once there is a new glow release. (and then wait for the next egui release? this sucks, maybe we should just temporarily patch this with git dependencies...) |
Looks like egui will fix this in 0.25 again, so lets wait for that I suppose: emilk/egui#3646 |
Annoying, but it it will eventually be fixed in an update, I suppose. |
This is now fixed, but needs update in smithay's glow (update to 0.13) for 0.25 and above |
PRs welcome :) |
We can see if things are working properly with the newly released glow 0.14, once emilk/egui#4833 is released. |
This currently fails to compile:
emilk/egui#3598 changed this to use
Rc
instead ofArc
. Smithay'sGlowRenderer::with_context
passes an&Arc<Context>
. Not sure what can be done other than Smithay usingRc
, or using a different glow context for egui...