Use bool instead of _Bool (may cause compilation error for Objective-C++ code) #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks :) |
cloudkite
added a commit
that referenced
this pull request
May 21, 2014
Use bool instead of _Bool (may cause compilation error for Objective-C++ code)
|
@cloudkite Perhaps this might be worthy of a new tag (0.5.1)? Because it leads to compilation error for some people. |
|
@nickynick yup just waiting on cocoapods trunk, which is coming end of this week apparently https://twitter.com/CocoaPods/statuses/469170830048759810 |
|
Yeah, it's a bit of a bummer, I was just about to submit a new pod :) |
|
pushed to trunk ;) |
dan-rodrigues
pushed a commit
to dan-rodrigues/Masonry
that referenced
this pull request
Oct 18, 2014
Use bool instead of _Bool (may cause compilation error for Objective-C++ code)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, Objective-C++ code may have troubles with understanding
_Booltype. I guess it has something to do with<stdbool.h>not being included. Or maybe not. Anyway, I believe it should be fine to just useboolinstead. It's not like all this makes much sense for Masonry, but still.I also moved
floatanddoublea bit higher because they do make sense for us :)