Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add the children requirements to the root composer.json #1275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add the children requirements to the root composer.json #1275

wants to merge 1 commit into from

Conversation

lucasmichot
Copy link
Member

Add the children requirements to the root composer.json

@lucasmichot lucasmichot requested a review from atymic October 22, 2024 16:17
@atymic
Copy link
Member

atymic commented Oct 24, 2024

What is the reasoning for this?

@lucasmichot
Copy link
Member Author

We need to ensure that we can still install all dependencies, depending on the PHP version

atymic
atymic reviewed Jan 3, 2025
View reviewed changes
Copy link
Member

@atymic atymic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to do this, we need to update the contribution guidelines to make sure people add it in their PRs. In addition, we might end up with conflicts between different drivers, how would we resolve that?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@atymic atymic atymic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasmichot @atymic