fix(windows): fix component import paths on windows #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoubleU23
force-pushed
the
fix/componentImportPathsWindows
branch
from
318d0d7 to
ce53092
Compare
|
Nice! When we can expect the merge? |
|
This is a major issue, this issue is kind of a blocker. Can we expect a quick merge please @wojtek-krysiak @chroventer |
|
@wojtek-krysiak @chroventer |
vis97c
added a commit
to vis97c/better-docs
that referenced
this pull request
Jul 25, 2020
This is a contribution to merge SoftwareBrothers#46 in which they fixed the react path but ignored the vue ones, also the cmd command is passed over cross-env package to make sure it works in any enviroment (linux/osx/windows)
This was referenced Jul 25, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #43
information
the path module, doesn't care about the platform (see nodejs/node#12298)
and since you used explicit
path.posix, relative paths didn't resolve correctly on windows.using
path.win32would lead to the correct fs paths,but we need the posix path to be written into the resulting component entry
to be discussed
there may be an more elegant way to convert the paths than using
.replace()changes
use
path.win32for windows platforms:const path = require('path')[process.platform === 'win32' ? 'win32' : 'posix']and transform component import paths with
pathCrossEnv()which replaces slashes to posix style if running on windows
system
tested on windows 10 in git bash
node v12.1.0
npm v6.13.0