Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[mobile - 13] Faculty details #25

Closed
AleksaZakrzewska opened this issue Dec 20, 2023 · 4 comments · Fixed by #110
Closed

[mobile - 13] Faculty details #25

AleksaZakrzewska opened this issue Dec 20, 2023 · 4 comments · Fixed by #110
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@AleksaZakrzewska
Copy link

AleksaZakrzewska commented Dec 20, 2023

When the user clicks on a faculty of choice in the "faculties" tab, information about the faculty appears.

AC1 A map with the location of the main faculty building according to the design mockup appears.

AC2 Information is given where the dean's office is located.

AC3 Listed are the faculties that operate in the faculty.

AC4 It refers to issue [mobile - 07] #13 - at the bottom of the page there are scientific circles in the form of a scrollable element, pressing the selected scientific circle takes you to information about this circle

Design mockup:
Image

@AleksaZakrzewska AleksaZakrzewska moved this to Todo in ToPWR Dec 20, 2023
@mikolaj-jalocha mikolaj-jalocha self-assigned this Jan 14, 2024
@mikolaj-jalocha mikolaj-jalocha removed their assignment Feb 13, 2024
@kamilfedio kamilfedio self-assigned this Mar 22, 2024
@kamilfedio kamilfedio removed their assignment Apr 4, 2024
@gry-mar gry-mar self-assigned this Apr 11, 2024
@gry-mar gry-mar moved this from Todo to In Progress in ToPWR May 14, 2024
@gry-mar gry-mar removed their assignment Jun 3, 2024
@kamilfedio kamilfedio moved this from In Progress to Todo in ToPWR Jun 22, 2024
@mikolaj-jalocha mikolaj-jalocha self-assigned this Jul 5, 2024
@mikolaj-jalocha
Copy link
Member

During coding some questions came up:

According to design:

  1. Map should be placed in the background and in the Dean's Office section compass should be displayed with infomation about detailed address

Image

  1. Beneath logo address of the Department should be displayed (clickable in my opinion to enchance UX)

Image

Our api provides this type of data regarding departments:

Image

  • Is the address of the department missing there along with coords for map? Or I'm missing sth (it could be that way 😝)
  • Does the code property reflect compass's data? (Dean's Office exact address inside building)?
  • Does the link property reflect fields of study? (On the screenshot "Architektura, Gospodarka Przestrzenna")
  • I belive study circles could be determined without need to include them in api response regarding deparments?
  • What isgradient_startand gradient_end property?

@simon-the-shark
Copy link
Member

  1. look like address is missing :P
  2. code is like W4 or W8
  3. links reflect this part I think (at least that was the intent)
Zrzut ekranu 2024-07-14 o 21 53 50
  1. field of studies are definietly added but maybe they're not open for the public api (yet :))
  2. same goes for departments, let me check permission on directus
  3. gradient are used to show the backgrounds here
Zrzut ekranu 2024-07-14 o 21 54 03

@simon-the-shark
Copy link
Member

UPDATE

  1. added address field
  2. fields of studies should be public now
  3. i see on playground scientific circles are not nested, but graphql still allows you to retrieve everything in single request, let me give you quick example

@simon-the-shark
Copy link
Member

i believe something like this works on our directus api. play around with it and I think you should be able to achieve +- everyhting.

query {
  Departments_by_id(id: 1) {
    name
    code
    logo {
      filename_disk
    }
    gradient_start
    gradient_end
    links {
      link
      name
    }
    code
    fieldsOfStudies {
      id
      name
    }
    address
  }
  Scientific_Circles(filter: {department: {id: {_eq: 1}}}  ){
    name
  }
}

also if you think we should change something on directus, let me know and we can arrange that. we can still adjust things there if you think something will be better some other way

@mikolaj-jalocha mikolaj-jalocha added the enhancement New feature or request label Jul 14, 2024
@mikolaj-jalocha mikolaj-jalocha moved this from Todo to In Progress in ToPWR Jul 20, 2024
@mikolaj-jalocha mikolaj-jalocha linked a pull request Jul 20, 2024 that will close this issue
simon-the-shark added a commit that referenced this issue Jul 21, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in ToPWR Jul 21, 2024
@simon-the-shark simon-the-shark added this to the v1.0.0 milestone Aug 26, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants