Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add youtube and github icon [MOBILE 53] #103

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Conversation

mikolaj-jalocha
Copy link
Member

MOBILE 53

  • add youtube and github icon
  • refactor function responsible for determining proper icon

- refactor function responsible for determining proper icon
Copy link
Member

@simon-the-shark simon-the-shark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note :P
Goodnight :)


extension IconDeterminer on String? {
String determineIcon() {
const icons = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this map should go to separate config file in /config dir?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Morning :-)
Good point, why not.

@simon-the-shark simon-the-shark merged commit a901eba into main Jun 21, 2024
@simon-the-shark simon-the-shark deleted the feat/ui-improvements branch June 21, 2024 11:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants