Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

#124 - parking typos - fix #168

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

mikolaj-jalocha
Copy link
Member

At first glance, I thought about setting the street address in the data layer, but then I thought about localization and finally ended up setting the "ul. " or "st. " prefix in the ui layer.

Screenshot

@mikolaj-jalocha mikolaj-jalocha linked an issue Aug 26, 2024 that may be closed by this pull request
@mikolaj-jalocha mikolaj-jalocha self-assigned this Aug 26, 2024
@mikolaj-jalocha mikolaj-jalocha added the bug Something isn't working label Aug 26, 2024
Copy link
Member

@simon-the-shark simon-the-shark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a util to watch locale changes using ref and not context, but here I think what you've done is def enough

@simon-the-shark simon-the-shark merged commit e9177dc into main Aug 26, 2024
2 checks passed
@mikolaj-jalocha mikolaj-jalocha deleted the fix/124-fix-parking-typos branch August 27, 2024 08:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

fix/ parking typos
2 participants