Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix / unknown trend on parking view #306

Merged
merged 8 commits into from
Oct 19, 2024
Merged

Fix / unknown trend on parking view #306

merged 8 commits into from
Oct 19, 2024

Conversation

mikolaj-jalocha
Copy link
Member

#300

  • If trend is unknown, no icon is displayed. Maybe we should consider using some kind of message? "Unable to determine trend", or maybe just leave it blank. In either way, imo both look better than question mark
  • I've also fixed some typos regarding parking's feature :-)

@mikolaj-jalocha mikolaj-jalocha added the bug Something isn't working label Oct 11, 2024
@mikolaj-jalocha mikolaj-jalocha added this to the v1.1.0 milestone Oct 11, 2024
@mikolaj-jalocha mikolaj-jalocha self-assigned this Oct 11, 2024
@mikolaj-jalocha mikolaj-jalocha linked an issue Oct 11, 2024 that may be closed by this pull request
fix/ "fikuśny" trend #300
Closed
@simon-the-shark simon-the-shark force-pushed the fix-/-unknown-trend-on-parking-view branch from da84c23 to 8d6da65 Compare October 17, 2024 22:29
@simon-the-shark simon-the-shark merged commit 4c0ec8c into main Oct 19, 2024
2 checks passed
@simon-the-shark simon-the-shark deleted the fix-/-unknown-trend-on-parking-view branch October 19, 2024 13:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@simon-the-shark simon-the-shark Awaiting requested review from simon-the-shark

Assignees

@mikolaj-jalocha mikolaj-jalocha

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.1.0 - Operation Squash-a-Bug
Development

Successfully merging this pull request may close these issues.

fix/ "fikuśny" trend
2 participants
@mikolaj-jalocha @simon-the-shark