Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so previously if there was a deeplink in some text or guide or smth we just opened it like any other and relied on the os system to open good tab in our app.
And it even kinda worked. But had some drawbacks:
IOS didn't work (xd) - generally in this scenario ios never works (at least that's what i read) so this change is needed here. If we open a link ios assume we can't handle it internally, which is not the case here. we need to handle it ourselves. Disclaimer: i don't think ios deeplinks work at all for our app, but this change removes the worst case where someone can notice it.
on android it worked but had one drawback: back button didn't move us back to the place where we opened it. Which imo is kinda bad UX. Now you can always make a nice return to the previous screen.