Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: handle in app deep links #347

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Conversation

simon-the-shark
Copy link
Member

so previously if there was a deeplink in some text or guide or smth we just opened it like any other and relied on the os system to open good tab in our app.

And it even kinda worked. But had some drawbacks:

  1. IOS didn't work (xd) - generally in this scenario ios never works (at least that's what i read) so this change is needed here. If we open a link ios assume we can't handle it internally, which is not the case here. we need to handle it ourselves. Disclaimer: i don't think ios deeplinks work at all for our app, but this change removes the worst case where someone can notice it.

  2. on android it worked but had one drawback: back button didn't move us back to the place where we opened it. Which imo is kinda bad UX. Now you can always make a nice return to the previous screen.

@simon-the-shark simon-the-shark added the enhancement New feature or request label Oct 26, 2024
@simon-the-shark simon-the-shark self-assigned this Oct 26, 2024
@simon-the-shark simon-the-shark added this to the v1.1.0 milestone Oct 26, 2024
@simon-the-shark simon-the-shark linked an issue Oct 26, 2024 that may be closed by this pull request
Copy link
Member

@mikolaj-jalocha mikolaj-jalocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fine and simple solution (but I imagine it wasn't that obvious from the start).
BTW deep link handling in our app'd be a great material for an article regarding deep links in complex situations. Assuming we somehow handle iOS's way of thinking 😝

@simon-the-shark
Copy link
Member Author

you can even do a solvro talk about it :P - assuming we fix the ios fully

@simon-the-shark simon-the-shark merged commit 9982b32 into main Oct 27, 2024
2 checks passed
@simon-the-shark simon-the-shark deleted the feat/handle-in-app-deeplinks branch October 27, 2024 11:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat/ handle in-app deeplinks in a bit more custom way
2 participants