Feat/ animate maps camera #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-the-shark
force-pushed
the
feat/animate-map-camera
branch
from
2bfbea6 to
a8391f1
Compare
mikolaj-jalocha
approved these changes
Oct 28, 2024
| @@ -27,7 +29,9 @@ class BuildingTile extends ConsumerWidget { | |||
| subtitle: context.changeNull(building.addressFormatted), | |||
| isActive: isActive, | |||
| onTap: () { | |||
| ref.read(buildingsMapControllerProvider.notifier).onMarkerTap(building); | |||
| unawaited( | |||
There was a problem hiding this comment.
Is this unawaited here because of linter complaints, or sth changed in whole logic that now it's async?
There was a problem hiding this comment.
it wasn't async and now it is due to few reasons:
- we do not have controller straight away, we use
Completerand await its completion - animation also takes time and is async, and previously camera jump wasn't async
| @@ -35,7 +37,9 @@ class BuildingsView extends ConsumerWidget { | |||
| point: item.location, | |||
| child: GestureDetector( | |||
| onTap: () { | |||
| ref.read(buildingsMapControllerProvider.notifier).onMarkerTap(item); | |||
| unawaited( | |||
| fl_map.MapController build() { | ||
| return fl_map.MapController(); | ||
| // nasty, but no other option I think | ||
| final _controllerCompleter = Completer<AnimatedMapController>(); |
There was a problem hiding this comment.
Is this Completer here because of build errors? Or could we just create AnimatedMapController.future?
There was a problem hiding this comment.
Completer is just a native dart way to await somewhere until someother part of the code completes with value (in very imperative way with .complete(value) - so imo ideal way in this example. But sure, there are few alternative ways to handle this. Riverpod provider could be a solution too, but more bulky
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nagranie.z.ekranu.2024-10-27.o.23.55.51.mov