fix syntax

SomeBlackMagic · Feb 13, 2024 · 7446fd9 · 7446fd9
1 parent ee5b49f
commit 7446fd9
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 8 deletions.
diff --git a/charts/kube-monitoring/Chart.yaml b/charts/kube-monitoring/Chart.yaml
@@ -2,8 +2,8 @@ apiVersion: v2
 name: kube-monitoring
 description: More rules for base kubernetes metrics
 type: application
-version: 0.3.0
-appVersion: 0.3.0
+version: 0.3.1
+appVersion: 0.3.1
 icon: https://raw.githubusercontent.com/SomeBlackMagic/helm-charts/master/charts/kube-monitoring/kube-monitoring.png
 keywords:
   - kube

diff --git a/charts/kube-monitoring/ci/default-values.yaml b/charts/kube-monitoring/ci/default-values.yaml
@@ -5,4 +5,4 @@ prometheus:
       foo: bar
 
 grafana:
-  enabled: true
+  enabled: false
diff --git a/...boards/kube-horizontal-po-autoscaler.json → ...oards/kube-horizontal-pod-autoscaler.json b/...boards/kube-horizontal-po-autoscaler.json → ...oards/kube-horizontal-pod-autoscaler.json
diff --git a/charts/kube-monitoring/templates/prometheus/prometheusrule.yaml b/charts/kube-monitoring/templates/prometheus/prometheusrule.yaml
@@ -55,8 +55,8 @@ spec:
     #https://stackoverflow.com/a/69340335
     - alert: FailedEvictedPods
       annotations:
-        summary: {{`Failed Evicted pod: {{ $labels.pod }}`}}
-        description: {{`Pod {{ $labels.namespace }}/{{ $labels.pod }} has been Evicted. Please check reason and remove evicted pod`}}
+        summary: "{{`Failed Evicted pod: {{ $labels.pod }}`}}"
+        description: "{{`Pod {{ $labels.namespace }}/{{ $labels.pod }} has been Evicted. Please check reason and remove evicted pod`}}"
       expr: sum by(namespace, pod) (kube_pod_status_phase{phase="Failed"} > 0 and on(namespace, pod) kube_pod_status_reason{reason="Evicted"} > 0) > 0
       for: 10m
       labels:
@@ -67,8 +67,8 @@ spec:
     #https://stackoverflow.com/a/69340335
     - alert: TooManyEvictedPodsOnNamespace
       annotations:
-        summary: {{`Too many Failed Evicted Pods in {{ $labels.namespace }}`}}
-        description: {{`Too many Failed Evicted Pods: {{ $value }} on namespace {{ $labels.namespace }}`}}
+        summary: "{{`Too many Failed Evicted Pods in {{ $labels.namespace }}`}}"
+        description: "{{`Too many Failed Evicted Pods: {{ $value }} on namespace {{ $labels.namespace }}`}}"
       expr: sum by(namespace) (kube_pod_status_reason{reason="Evicted"}) >= {{ $.Values.prometheus.rule.alerts.tooManyEvictedPods.threshold }}
       labels:
         severity: "{{ $.Values.prometheus.rule.alerts.tooManyEvictedPods.severity }}"

diff --git a/charts/kube-monitoring/validate.sh b/charts/kube-monitoring/validate.sh
@@ -1 +1,3 @@
-helm install --debug --dry-run app -f ci/default-values.yaml .
+#helm lint .
+helm template . --debug --values ci/default-values.yaml
+#helm install --debug --values ci/default-values.yaml --dry-run app .