Skip to content

Kellyroach/swift4 #6

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kellyroach
Copy link

This pull request updates pods and code in the MLKit repo to Xcode 9.4.1 / Swift 4.2 .
Currently, there are a number of yellow and red compiler issues with
the MLKit-Example as checked out. E.g.:

  • Converstion to Swift 4 is available
  • Update to recommended settings
  • error: generic parameter 'ML' is not used in function signature
  • warning: redundant conformance constraint 'Self': 'Hashable'
  • error: 'Sequence' requires the types 'Span.Element' (aka 'CountableClosedRange') and '[Int]' be equivalent

Our pull request fixes these compilation issues with MLKit-Example .
We've also added an AppIcon and LaunchImage to the demo app.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant