Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve S1192 by ignoring literals in type annotations #2464

Closed
yassin-kammoun-sonarsource opened this issue Jan 22, 2021 · 0 comments · Fixed by SonarSource/eslint-plugin-sonarjs#203
Closed

Improve S1192 by ignoring literals in type annotations #2464

yassin-kammoun-sonarsource opened this issue Jan 22, 2021 · 0 comments · Fixed by SonarSource/eslint-plugin-sonarjs#203
Assignees
@yassin-kammoun-sonarsource
Labels
type: enhancement Improving existing functionality type: false positive Issue is reported when it should NOT be
Milestone
7.4

Comments

@yassin-kammoun-sonarsource
Copy link
Contributor

Example:

let x: 'Hello world' = 'Hello world'
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource added type: false positive Issue is reported when it should NOT be hardening labels Jan 22, 2021
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource added this to the 7.3 milestone Jan 22, 2021
Closed
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource removed this from the 7.3 milestone Mar 25, 2021
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource added this to the 7.4 milestone Apr 9, 2021
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource added the type: enhancement Improving existing functionality label Apr 9, 2021
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource changed the title Improve S1192 by ignoring literals in type definitions Improve S1192 by ignoring literals in type annotations Apr 13, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource

Labels
type: enhancement Improving existing functionality type: false positive Issue is reported when it should NOT be
Projects
None yet
Milestone
7.4
Development

Successfully merging a pull request may close this issue.

Improve S1192 by ignoring literals in type annotations SonarSource/eslint-plugin-sonarjs
2 participants
@saberduck @yassin-kammoun-sonarsource