This repository has been archived by the owner on Oct 3, 2024. It is now read-only.
Improve S1192 by ignoring literals in type annotations #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassin-kammoun-sonarsource
force-pushed
the
yassin/S1192
branch
from
1491cc5
to
580890e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
saberduck
reviewed
Apr 13, 2021
| @@ -20,6 +20,7 @@ | |||
| import { RuleTester } from "eslint"; | |||
|
|
|||
| const ruleTester = new RuleTester({ | |||
| parser: require.resolve("@typescript-eslint/parser"), | |||
There was a problem hiding this comment.
can we use RuleTesterJsWithTypes from Andrea?
There was a problem hiding this comment.
Well, the class is defined in SonarJS, therefore not available in eslint-plugin-sonarjs. However, we could temporarily duplicate its implementation here in eslint-plugin-sonarjs, create a ticket to remove the one in SonarJS, and eventually use eslint-plugin-sonarjs's one once we release it.
What do you think ?
There was a problem hiding this comment.
There was a problem hiding this comment.
yep, that could be a good idea, however maybe in separate PR, I would merge this as is
saberduck
approved these changes
Apr 13, 2021
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2464