Skip to content
This repository has been archived by the owner on Oct 3, 2024. It is now read-only.

Commit

Permalink
Drop Node.js 14 support and test against Node.js 20 on CI (#445)
Browse files Browse the repository at this point in the history
  • Loading branch information
yassin-kammoun-sonarsource authored Feb 9, 2024
1 parent e95d75d commit a668054
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,15 @@ qa_task:
- build
eks_container:
matrix:
- docker_arguments:
NODE_VERSION: 14
CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT}
- docker_arguments:
NODE_VERSION: 16
CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT}
- docker_arguments:
NODE_VERSION: 18
CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT}
- docker_arguments:
NODE_VERSION: 20
CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT}
<<: *CONTAINER_DEFINITION
cpu: 3
memory: 8G
Expand Down
3 changes: 2 additions & 1 deletion .cirrus/nodejs.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ USER root
ARG NODE_VERSION=18
ARG SCANNER_VERSION=5.0.1.3006

RUN apt-get update && apt-get install -y nodejs=${NODE_VERSION}.*
RUN curl -fsSL https://deb.nodesource.com/setup_${NODE_VERSION}.x | bash - \
&& apt-get install -y nodejs=${NODE_VERSION}.*

RUN curl "https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-${SCANNER_VERSION}.zip" -o /tmp/sonar-scanner.zip \
&& unzip -d /opt /tmp/sonar-scanner.zip \
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Code Smells, or maintainability issues, are raised for places of code which migh

## Prerequisites

- Node.js (>=14.x).
- Node.js (>=16.x).
- ESLint 5.x, 6.x, 7.x or 8.x (peer dependency for the plugin).

## Usage
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"homepage": "https://github.com/SonarSource/eslint-plugin-sonarjs",
"engines": {
"node": ">=14"
"node": ">=16"
},
"scripts": {
"build": "rimraf lib && tsc -d -p tsconfig.json",
Expand Down

0 comments on commit a668054

Please # to comment.