fixes for memory and error status leaks in parse cert #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reopening this, and apologies for it taking so long to get back to you. This looks perfectly fine to me. Going to merge it in and will release it in 0.3.2 some time this week, most likely on Friday. |
|
Yup. Gonna check that one out too and hopefully get it in 0.3.2 on Friday as well... though I'm debating on bumping it to 0.4.0 with that change since it does change the API. :) |
|
Just an update, didn't forget about this. Had some stuff come up that prevented me from getting to it on Friday. 0.3.2 should now be on NPM. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing this module, I found some issues with memory leaking from the parseCert method (one was already fixed in 3.1, but I found others).
I also found that ssl error statuses are not always cleared. Under the right circumstances the uncleared errors are picked up by other parts of node.js that also use openssl. This can cause some unintended (and sometimes spectacular) side-effects.
@Southern